Add sanitizer CI job #703
Open
Add sanitizer CI job #703
+524
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretambrose
reviewed
Dec 3, 2024
| @@ -71,6 +71,8 @@ def run(self, env): | |||
| '-DCMAKE_BUILD_TYPE=RelWithDebInfo']) | |||
| # append extra cmake configs | |||
| steps[-1].extend(cmd_args.cmake_extra) | |||
| if sys.platform == "linux" or sys.platform == "linux2": | |||
There was a problem hiding this comment.
Feels like we're repeating the exact same loop 4 times here.
| @@ -24,6 +24,14 @@ if (UNIX AND NOT APPLE) | |||
| find_package(IotDeviceCommon-cpp REQUIRED) | |||
| find_package(IotDeviceDefender-cpp REQUIRED) | |||
|
|
|||
| target_link_libraries(${PROJECT_NAME} AWS::aws-crt-cpp AWS::IotDeviceCommon-cpp AWS::IotDeviceDefender-cpp) | |||
| if (ENABLE_SANITIZERS AND UNIX AND NOT APPLE) | |||
There was a problem hiding this comment.
Would it be better to turn this into a small sharable function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.